Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vscode's editor.tabSize / editor.insertSpaces? #117

Open
scamden opened this issue Nov 10, 2017 · 4 comments
Open

support vscode's editor.tabSize / editor.insertSpaces? #117

scamden opened this issue Nov 10, 2017 · 4 comments

Comments

@scamden
Copy link

scamden commented Nov 10, 2017

Would be really nice to be able to control indent formatting with these two options. It seems the current options supported are only "typescript.format.etc"

@vvakame
Copy link
Owner

vvakame commented Nov 10, 2017

What is the your expected behavior?
editor.tabSizetabSize ?
editor.insertSpacesconvertTabsToSpaces ?

tabSize is exists in ts.EditorSettings interface, but it is not used in tsfmt now.

vvakame added a commit that referenced this issue Nov 10, 2017

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@scamden
Copy link
Author

scamden commented Nov 10, 2017

i believe the appropriate behavior is that editor.tabSize would be tabSize normally but if editor.insertSpaces == true then editor.tabSize would indicate indentSize. would that be possible?

@vvakame
Copy link
Owner

vvakame commented Nov 11, 2017

when convertTabsToSpaces: true, tab char replaced by indentSize: x at current typescript implementation.
I think if you want to use "editor.insertSpaces": true, use "editor.indentSize": x.

@scamden
Copy link
Author

scamden commented Nov 11, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants