-
Notifications
You must be signed in to change notification settings - Fork 102
Add babel #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add babel #9
Conversation
Thanks, but latest uglifyjs handles ES2015 just fine. I don't see a need to transpile. FYI this library requires native ES2015 so transpiling won't make it work in older browsers either. |
Thanks. If it's not too much trouble, would you mind elaborating a bit on the dependency this library has on native ES2015 support, such that transpiling and/or polyfills wouldn't help? I may need to support a bit of IE11 traffic, at least for a while, so I'm trying to understand my options. Thanks again, nice library. |
Custom Elements requires native ES2015 classes so that it can extend TL;DR: don't use web components in browsers that do not support it natively, otherwise you are just getting more trouble than benefits. |
Thanks, makes sense. I'm going to see if I can make this work in my fork -- looks like the issue you're discussing re: I understand that, even if that works, you probably don't want to clutter up your project with a bunch of extra stuff just for IE11 support. In my case, I can't quite throw IE11 overboard just yet, so maybe this will help me and any others in my situation. I'll reply back to let you know how it goes, just in case you're interested. |
Just to close the loop here, I was able to get this to work in IE11 using the above approach, in this fork. I'm just publishing it privately for my own use. Thanks for the help and guidance. |
@galenwarren That's cool. I also need IE11 support. |
@allenhwkim I could do that -- but let's check first to see if this is something that @yyx990803 would want to merge. |
It's truly a shame that we can't bring some ie11 to this project. I understand that it's not easy for a maintainer to maintain, but its still a shame having to use forks. |
Wondering if you might be interested in a PR that transpiles the code that goes into the dist folder? I'm using your library -- and it's great! -- but this library is flagged as containing code that is not transpiled to ES5, as described here which causes problems in some bundling scenarios.
Also, I unfortunately need to support some older browsers, so I'm hoping this will help with that problem as well.