Remove useless spread and fallbacks #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI error seems to be from the main branch, I will fix that later. |
ota-meshi
reviewed
Mar 5, 2025
| @@ -95,7 +95,7 @@ export function extractGeneric(element: VElement): GenericProcessInfo | null { | |||
| typeDefScope: Scope, | |||
| isRemoveTarget: (nodeOrToken: HasLocation) => boolean, | |||
| ) { | |||
| for (const variable of [...typeDefScope.variables]) { | |||
| for (const variable of typeDefScope.variables) { | |||
There was a problem hiding this comment.
It's just sharing, we had to copy the original array because it might be modified, so we'll undo this modification.
There was a problem hiding this comment.
Thanks, sorry about it.
There was a problem hiding this comment.
The tests should have caught that, but it seems I broke them. Sorry 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reading code, and found some cases that unicorn can prevent.
If you don't want keep the rules, I can remove them.
BTW: The eslint config seems not working right, when I run
eslint --fix, there are more change (some are wrong) applied, maybe because of version of dependencies.