feat!: turn on modern mode by default, and provide a --no-module option
#6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--no-modern` sounds weird, so I prefer the `--no-module` option. But `--no-modern` is kept for the convenience of implementation, could be removed later.
TODO: shall we rename `--modernBuild` too?
Don't have the time to fix the tests after changing the default value of modern mode. So I'll leave that for later.
Now that modern mode is on by default, the build time increases too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-modulename over--no-modernbecause I think it better reflects the actual usage ofscript type="module". And the base browser targets for ES module support isn't that modern as we are now at years after its initial introduction.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
I'm also working on a
--module-onlyoption in a separate PR.