Skip to content

feat: transpile dependencies in node_modules #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang haoqunjiang commented Jan 20, 2021

TODOs:

  • A simplified dependencies babel preset for node_modules, to reduce the performance overhead I don't think there will be much overhead because the default preset only adds very few custom features. It would also be against the users' intention if they choose a different preset for their project
  • Decide whether to opt-in or opt-out of this feature Should be opt-out. And we should continue improving the cache configuration to speed up incremental builds.
  • Test cases
  • Revise the transpileDependencies documentation
  • Mention this feature in the migration documentation

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@haoqunjiang haoqunjiang changed the title feat!: transpile dependencies in node_modules by default feat: transpile dependencies in node_modules Jan 20, 2021
@haoqunjiang
Copy link
Member Author

🤔 I think it might make more sense to reuse the existing transpileDependencies option than to add a new command-line flag.

I'll work on a new PR to just accept transpileDependencies: true as an option to transpile all dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant