feat: open browser when toast clicked #6001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony19
force-pushed
the
feat/toast-callback
branch
from
f2edd09 to
934fa3d
Compare
tony19
commented
Oct 24, 2020
| @@ -6,10 +6,15 @@ const builtinIcons = { | |||
| error: path.resolve(__dirname, '../../src/assets/error.png') | |||
| } | |||
|
|
|||
| let notifCallback = null | |||
There was a problem hiding this comment.
notifCallback can be null, which is safe because node-notifier defaults it to a no-op.
tony19
force-pushed
the
feat/toast-callback
branch
from
934fa3d to
6b581bd
Compare
|
Thanks! This PR looks good. Could you please fix the merge conflicts here so that I can merge it? |
|
@sodatea Ok, resolved merged conflicts. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, clicking the toast notification from Vue UI has no effect other than closing the notification. This PR opens a browser to the originating Vue UI upon notification click.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
node-notifier5/6 has a bug in Windows that does not forward notification-click events, so this change will only work on other platforms until that gets fixed.