fix: do not introduce extra level of directory when building lib for scoped packages #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild if scoped package name is used vuejs#4311"
haoqunjiang
requested changes
Jul 19, 2019
There was a problem hiding this comment.
Please fix the failing test.
For the vue build command, api.service.pkg.name may be undefined.
haoqunjiang
approved these changes
Jul 22, 2019
|
Looks better now. Sorry I wasn't able to get your test suite running at work. That's why I used only your circleci which only runs after creating a PR. |
haoqunjiang
added
PR: Breaking Change
PR: Bug Fix
and removed
PR: Breaking Change
labels
haoqunjiang
changed the title
|
Hey @MewesK, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4311 for more information