Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change vue-eslint-parser to peer dependency #2670

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Change vue-eslint-parser to peer dependency #2670

merged 1 commit into from
Jan 29, 2025

Conversation

ota-meshi
Copy link
Member

This PR changes vue-eslint-parser to peer dependency.

I make it easy to change the version used by making vue-eslint-parser a peer dependency.
Also, recent npm installs peer dependencies automatically by default, so I don't think it will be inconvenient for users.

@FloEdelmann FloEdelmann changed the title Change vue-eslint-parser to peer dependency Change vue-eslint-parser to peer dependency Jan 29, 2025
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@ota-meshi ota-meshi merged commit be3ff99 into v10 Jan 29, 2025
14 checks passed
@ota-meshi ota-meshi deleted the parser-deps branch January 29, 2025 10:58
waynzh pushed a commit that referenced this pull request Feb 20, 2025
ota-meshi added a commit that referenced this pull request Mar 5, 2025
ota-meshi added a commit that referenced this pull request Mar 5, 2025
@mbrodala
Copy link
Contributor

mbrodala commented Mar 5, 2025

For completeness: this does not work with Yarn which does not install peer dependencies by default but warns that they are missing:

warning " > eslint-plugin-vue@10.0.0" has unmet peer dependency "vue-eslint-parser@^10.0.0".

See yarnpkg/yarn#1503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants