Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly type title style #210

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fix: correctly type title style #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ const HiddenItemWrappedTwice = ()=> <HiddenItemWrapped />
| ---------------------- | ------------------------------------------------------------------ | ---------------------------------------------------------------------- |
| title: string | title for the button, required | |
| style?: ViewStyle | style to apply to the touchable element that wraps the text | |
| titleStyle?: ViewStyle | style to apply to the text | |
| titleStyle?: TextStyle | style to apply to the text | |
| onPress: ?() => any | function to call on press | |
| testID?: string | testID to locate view in e2e tests | |
| disabled?: boolean | disabled 'item' is greyed out and `onPress` is not called on touch | |
Expand Down
3 changes: 2 additions & 1 deletion src/overflowMenu/vendor/MenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
GestureResponderEvent,
StyleSheet,
Text,
TextStyle,
View,
ViewStyle,
} from 'react-native';
Expand Down Expand Up @@ -31,7 +32,7 @@ export type Props = {
* @optional
*/
style?: ViewStyle;
titleStyle?: ViewStyle;
titleStyle?: TextStyle;
/**
* TestID used for testing purposes
*/
Expand Down