Skip to content

Conversation

ruslankrivoshein
Copy link

I don't know how clumsy this method is, but it helps me in the next case:

{
  "action": "edit",
  "data[1][title]": "title",
  "data[1][files][]": 1,
  "data[1][files][]": 2,
  "data[1][files][]": 3
}

Existing tests pass successfully, but it's useful to cover the fix case as well.

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #5 into master will decrease coverage by 0.37%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage     100%   99.62%   -0.38%     
==========================================
  Files           4        4              
  Lines         266      270       +4     
==========================================
+ Hits          266      269       +3     
- Misses          0        1       +1
Impacted Files Coverage Δ
rest_framework_datatables_editor/viewsets.py 98.24% <80%> (-1.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8920b87...9d22304. Read the comment docs.

@vertliba vertliba force-pushed the master branch 2 times, most recently from 7f151fe to 1e1b8b2 Compare May 16, 2020 23:16
@vertliba
Copy link
Owner

I don't know how clumsy this method is, but it helps me in the next case:

{
  "action": "edit",
  "data[1][title]": "title",
  "data[1][files][]": 1,
  "data[1][files][]": 2,
  "data[1][files][]": 3
}

Existing tests pass successfully, but it's useful to cover the fix case as well.

Hi @ruslankrivoshein!.
Thank you for your contribution!
Could you rebase the PR to the latest version and add tests for that case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants