Add support for using .babelrc in the app root. #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing |
|
@rauchg Oh! I forgot that :) |
|
@rauchg done. |
rauchg
reviewed
Dec 24, 2016
| } | ||
| ``` | ||
|
|
||
| Although it's not required, you will need to add `next/babel` as a preset. That's the default preset we use for all Next.js apps. |
There was a problem hiding this comment.
so, we removed support for babel in next.config.js right? Otherwise, we also have to make a mention of that here
There was a problem hiding this comment.
We removed that. Now there's no such option.
|
@arunoda needs re-base 🙏 |
|
@rauchg done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #466
And allows to configure babel via the
.babelrcfile.If there's no such file, we'll add our preset
next/babelby default. If not we'll use the.babelrcfile.Most of the time, user need to add
next/babelas a preset.If we are taking this in, we could support ES2015 in the
config.next.jsas well.