Make next/router a client only API. #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
arunoda
changed the title
1 similar comment
arunoda
commented
Dec 20, 2016
| @@ -6,7 +6,7 @@ let router = null | |||
| const SingletonRouter = {} | |||
|
|
|||
| // Create public properties and methods of the router in the SingletonRouter | |||
| const propertyFields = ['route', 'components', 'pathname', 'query'] | |||
| const propertyFields = ['components', 'pathname', 'route', 'query'] | |||
There was a problem hiding this comment.
@nkzawa I think we still need to keep these because they are pretty useful when doing custom routing.
If used for rendering, it'll throw an error in the SSR process.
So, I think that's fine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
next/routerinside the server makes API unpredictable and we cannot support it anywhere.So, with this PR now we are making this as a client side API.