Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deprecate url.pushTo and url.replaceTo warnings only on dev. #434

Merged
merged 1 commit into from
Dec 19, 2016

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Dec 19, 2016

In order to warn the user, now we are using a warn function
which is located in the lib/utils module.

In order to warn the user, now we are using a warn function
which is located in the lib/utils module.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 58.501% when pulling 1e333a0 on arunoda:warn-push-to-only-in-dev into e45cc89 on zeit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 58.501% when pulling 1e333a0 on arunoda:warn-push-to-only-in-dev into e45cc89 on zeit:master.

@arunoda arunoda changed the title Update url.pushTo and url.replaceTo update only on dev. Show deprecate url.pushTo and url.replaceTo warnings only on dev. Dec 19, 2016
if (process.env.NODE_ENV !== 'production') {
console.error('Warning: \'next/css\' is deprecated. Please use styled-jsx syntax instead.')
}
warn('Warning: \'next/css\' is deprecated. Please use styled-jsx syntax instead.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we have the wiki page up for glamor, we can link directly to it from here, instead of this half-baked suggestion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@rauchg rauchg merged commit 565bb57 into vercel:master Dec 19, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants