Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console.logs #402

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Remove console.logs #402

merged 1 commit into from
Dec 16, 2016

Conversation

arunoda
Copy link
Contributor

@arunoda arunoda commented Dec 16, 2016

Remove dev time console.logs added with the service worker code.

@@ -1,13 +1,14 @@
/* global self */

const CACHE_NAME = 'next-prefetcher-v1'
const log = () => {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, logging is pretty useful when debugging.
So, we keep a log function like this and we can change it to console.log.bind(console) when we need to do some logging.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 34.271% when pulling e89b624 on arunoda:prefetcher-no-logs into aa6870a on zeit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 34.271% when pulling e89b624 on arunoda:prefetcher-no-logs into aa6870a on zeit:master.

@nkzawa nkzawa merged commit 43b0e6f into vercel:master Dec 16, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants