fix promise leak #57
fix promise leak #57
Conversation
| request.log(to: self.logger) | ||
| let promise = self.channel.eventLoop.makePromise(of: Void.self) | ||
| let request = PostgresRequestContext(delegate: request, promise: promise) | ||
| self.channel.write(request).cascadeFailure(to: promise) |
There was a problem hiding this comment.
hmm, I don't think this can fix a promise leak, right? If anything this will make it more likely that the promise is never fulfilled. Also, this is missing a test I think?
sorry, misunderstood you. I thought you meant you leaked the unfulfilled promise but I think you mean that the old code causes a memory leak involving the promise. I still don't think this change would make that go away. The reference to promise should be dropped as soon as the self.channel.write(request) future is either fulfilled or failed.
I really don't think this can fix a memory leak. It might however cause promise to be deallocated quicker as the new code doesn't keep it around until self.channel.write(request) future is done.
| } | ||
| } | ||
|
|
||
| extension Double: PostgresDataConvertible { |
There was a problem hiding this comment.
this and the change below seem unrelated?
|
thanks @tanner0101 |
3 participants
Fixes a promise leak caused by chaining the request completion promise to the channel write.