-
-
Notifications
You must be signed in to change notification settings - Fork 82
Add async option to PSQLRowStream #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async option to PSQLRowStream #206
Conversation
bad047c
to
b3e425e
Compare
Codecov Report
@@ Coverage Diff @@
## main #206 +/- ##
==========================================
+ Coverage 39.99% 47.12% +7.12%
==========================================
Files 118 119 +1
Lines 7693 8238 +545
==========================================
+ Hits 3077 3882 +805
+ Misses 4616 4356 -260
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from some minor nits, what amount of the state machine my brain can keep in its working set at one time seems fine, I have no issue with it.
c8b8114
to
2a427b1
Compare
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
Co-authored-by: Gwynne Raskind <gwynne@darkrainfall.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose I'll have to live with it like this 🤣
Motivation
To allow async/await querying we need to support AsyncSequences.
Changes
PSQLRowSequence
PSQLRowStream
to supportPSQLRowSequence
Result