-
-
Notifications
You must be signed in to change notification settings - Fork 80
DataRow without allocation; DataRow as Collection; RowDescription top level #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bfa6fdf
to
9b87c14
Compare
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 35.75% 39.85% +4.10%
==========================================
Files 115 115
Lines 7741 7795 +54
==========================================
+ Hits 2768 3107 +339
+ Misses 4973 4688 -285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor nits and questions, nothing serious.
Tests/PostgresNIOTests/New/Extensions/PSQLBackendMessage+Equatable.swift
Outdated
Show resolved
Hide resolved
Tests/PostgresNIOTests/New/Extensions/PSQLBackendMessageEncoder.swift
Outdated
Show resolved
Hide resolved
c0a6ab4
to
797055c
Compare
797055c
to
02aa7fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now 🙂
These changes are now available in 1.6.4 |
This is a cherry pick of #188.
Modifications
DataRow
andRowDescription
have been moved out of thePSQLBackendMessage
namespace. This allows us to mark them as@inlinable
or@usableFromInline
at a later point, without marking everything inPSQLBackendMessage
as@inlinable
DataRow
does not use an internal array for its columns anymore. Instead all read operations are directly done on its ByteBuffer slice.DataRow
implements theCollection
protocol now.Result
One allocation fewer per queried row.