Close connection if requestTLS fails #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwynne
approved these changes
Dec 9, 2020
Member
gwynne
left a comment
gwynne
left a comment
There was a problem hiding this comment.
LGTM; I'd like to see a test, but the change is very straightforward and a meaningful test might be difficult enough to construct that I'm (more or less) okay without one. Please do add one if you can, though.
Member
Author
|
@gwynne test added. Remove the fix, tests crash. Add fix, tests pass |
gwynne
approved these changes
Dec 10, 2020
Member
|
These changes are now available in 1.4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly close the PostgreSQL connection if
requestTLSfails.Resolves #133