Skip to content

Added create/drop trigger dialect conditions #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 13, 2020
Merged

Added create/drop trigger dialect conditions #169

merged 4 commits into from
Feb 13, 2020

Conversation

grosch
Copy link
Contributor

@grosch grosch commented Jan 24, 2020 •
edited
Loading

Updates the package to specify syntax that PostgreSQL supports for triggers.

@tanner0101 tanner0101 added the enhancement New feature or request label Feb 10, 2020
@tanner0101 tanner0101 added the semver-minor Contains new APIs label Feb 13, 2020
tanner0101
tanner0101 reviewed Feb 13, 2020
View reviewed changes
Copy link
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a PR body for the release notes. We should also update the Package.swift here to require the SQLKit version that adds SQLTriggerSyntax.

@tanner0101 tanner0101 merged commit 222dcf7 into vapor:master Feb 13, 2020
@tanner0101
Copy link
Member

These changes are now available in 2.0.0-beta.3.6

@tanner0101
Copy link
Member

Thanks @grosch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grundoon grundoon grundoon left review comments

@tanner0101 tanner0101 tanner0101 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request semver-minor Contains new APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grosch @tanner0101 @grundoon