Fix quant model param fetch regex #2662
Merged
+32
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the regex used to extract the approximate parameter count from model names in the quantization module, addressing issues with decimal values and lower-case “b” identifiers.
- Introduces a new helper function extract_approx_params_from_config to extract the parameter count from the model configuration.
- Updates get_model_param_count to use the new extraction function while removing the previous basic regex calculation.
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the regex used for extracting approximate parameter counts from model configuration strings, addressing issues with decimal numbers in model names and lower-case "b" identifiers.
- Introduces a new helper function extract_approx_params_from_config.
- Updates get_model_param_count to use the new extraction function instead of the basic regex.
| lowercase_b_families = ["gemma"] # gemma uses small 'b' : google/gemma-3-1b-it | ||
| model_name = getattr(config, "name_or_path", "") | ||
| import re | ||
| cleaned = re.sub(r"[-_]?bnb[-_]?4bit|[-_]?4bit|[-_]?8bit|[-_]?bnb", "", model_name, flags=re.IGNORECASE) # replace bnb and xbit |
There was a problem hiding this comment.
The regex substitution comment mentions 'xbit', but the pattern does not match any 'xbit' strings. Please update either the comment or the regex to correctly handle 'xbit' if intended.
Suggested change
| cleaned = re.sub(r"[-_]?bnb[-_]?4bit|[-_]?4bit|[-_]?8bit|[-_]?bnb", "", model_name, flags=re.IGNORECASE) # replace bnb and xbit | |
| cleaned = re.sub(r"[-_]?bnb[-_]?4bit|[-_]?4bit|[-_]?8bit|[-_]?bnb|[-_]?xbit", "", model_name, flags=re.IGNORECASE) # replace bnb and xbit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2661
The current regex is very basic and doesn't consider the following scenarios for example
I don't know if there are any. But I've tested with a few popular models and it works.
Note: Picking the param count from model name is not 100% accurate but is decent enough estimate.