-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Registry refactor #2255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Registry refactor #2255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danielhanchen
Refactor of PR #2231
From prior PR:
Model Registry
Structure
Each model is registered in a separate file within the
registrymodule (e.g.registry/_llama.py).Within each model registration file, a high-level
ModelMetais created for each model version, with the following structure:Each model then instantiates a global
ModelMetafor its specific model version, defining how the model path (e.g.unsloth/Llama-3.1-8B-Instruct) is constructed since each model type has a different naming convention.LlamaModelInfois a subclass ofModelInfothat defines the model path for each model size and quant type.Once these constructs are defined, the model is registered by writing a register_xx_models function.
_register_modelsis a helper function that registers the model with the registry. The global_IS_XX_REGISTEREDis used to prevent duplicate registration.Once a model is registered, registry.registry.MODEL_REGISTRY is updated with the model info and can be searched with
registry.search_models.Tests
The
tests/test_model_registry.pyfile contains tests for the model registry.Also, each model registration file is an executable module that checks that all registered models are available on
huggingface_hub.Prints the following (abridged) output:
TODO