fix(quasar): replace require() by readFileSync() in QuasarResolver #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't we use the async version? |
|
No reason not to, but the current implementation is synchronous so I wasn't sure if changing it might break current implementations. |
|
Let's use the async version then. The resolver should support async usage. |
antfu
changed the title
|
@stefanvanherwijnen I just wanted to let you know that these changes didn't make a difference on my current project (#332) but thanks anyway ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
"type": "module", QuasarResolver leads torequire() is not definederrors.Because
import()of JSON files is not supported yet, the solution is to use readFileSync for now (and resolve the path withlocal-pkg).This might also solve #332