Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arco): new option sideEffect #338

Merged
merged 2 commits into from
Mar 24, 2022
Merged

feat(arco): new option sideEffect #338

merged 2 commits into from
Mar 24, 2022

Conversation

aolyang
Copy link
Contributor

@aolyang aolyang commented Mar 24, 2022

arco-design/arco-design-vue#864

添加一个类型正确的配置(importStyle可以赋值空字符串绕过,但类型不符合),可以让按需引入组件时,不引入样式文件,以达到不覆盖Arco主题包的目的。这个属性如果不使用将不会对原来的配置有任何影响。

@aolyang aolyang requested a review from antfu as a code owner March 24, 2022 03:04
*
* @default false
*/
disableSideEffect?: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
disableSideEffect?: false
sideEffect?: boolean

and default to true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@antfu antfu changed the title ArcoDesignVue add option disableSideEffect to disable style import feat(arco): new option sideEffect Mar 24, 2022
@antfu antfu merged commit e6e3fe4 into unplugin:main Mar 24, 2022
@aolyang
Copy link
Contributor Author

aolyang commented Mar 24, 2022

👌,感谢大佬

@aolyang aolyang deleted the feat/arco branch March 24, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants