Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in MaxDate comment #2423

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

namandeep-123
Copy link
Contributor

Description

Correct typo in maxDate comment, MaxDate determines whether the value is a date that falls on or before the given date.
But in a comment, it says "After" so I fix the Typo.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fix: Typo in MaxDate comment

fixes #2422, fixes #2422

@braaar braaar changed the title Fix Typo in MaxDate comment fix: typo in MaxDate comment Mar 19, 2024
Copy link
Member

@braaar braaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@braaar braaar merged commit 2ab6618 into typestack:develop Mar 19, 2024
5 checks passed
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: Typo in MaxDate comment
2 participants