Skip to content

Conversation

meteora2002
Copy link
Contributor

finished the json file in simple language

this is my github contribution .feel free to give constructive feedbacks

this is my github contribution .feel free tog give constructive feedbacks
@tuladhar
Copy link
Owner

tuladhar commented Oct 9, 2020

Congrats @meteora2002 on your first contribution. I suggest you to make README a bit more readable using correct formatting, currently, it does look rightly formatted.

@meteora2002
Copy link
Contributor Author

done

@meteora2002
Copy link
Contributor Author

@tuladhar please accept my pull requests

@tuladhar
Copy link
Owner

Thanks @meteora2002 I've requested for some changes, please check.

@meteora2002
Copy link
Contributor Author

@tuladhar please check my pull request

README.md Outdated
.It is the exact opposite of json.loads.
## THIS IS THE ENCODING DECODING LIST
| JSON| Python |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table is still not showing up correctly.

README.md Outdated
-json.dumps() function converts a Python object into a json string
.It is the exact opposite of json.loads.
## THIS IS THE ENCODING DECODING LIST
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use normal text for it, and remove the heading formatting.

README.md Outdated
- `Decoding is from JSON to python(final type)`
## other commands
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename it to "Encoding functions"

README.md Outdated
`infile`-to check your Json file for syntax
`outfile`-Write the output of the infile to the given outfile
## note
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's capitalize it.

@meteora2002
Copy link
Contributor Author

done

@meteora2002
Copy link
Contributor Author

@tuladhar please check my pull request

README.md Outdated
THIS IS THE ENCODING DECODING LIST
| JSON |Python |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table is still not showing. You can learn about it here:

@tuladhar
Copy link
Owner

Also, @meteora2002 let's remove the "coming soon" label from the contents table for JSON and add link.

Screen Shot 2020-10-13 at 12 05 57

Copy link
Owner

@tuladhar tuladhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meteora2002 for your contributions. Looks good to merge!

@tuladhar tuladhar merged commit 4184e29 into tuladhar:main Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants