added missing argument in autofocus directive Class #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I notice right now that $timeout is not accessible in the link method because it is not assigned to a property of the object. If you have time it would be nice if you could add this. :) |
|
Was literally about to post that |
|
Yes! I had missed that. I will add and update now |
|
Done. Is there anything else I have missed? |
|
Don't think so, if you have 30seconds to paste the same code inside the translated files ( |
|
Sure. Will do now |
further additions to constructor Changed constructor code in translations
|
done |
|
Perfect, thanks so much for the help :)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted that the constructor in the Class for the autofocus directive was missing the injected $timeout. See the below image for context.
I went ahead and made the change.