-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
gh: add page #3854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh: add page #3854
Conversation
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
pages/common/gh.md
Outdated
|
||
`gh pr checkout` | ||
|
||
- Check on the status of your pull requests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Check on the status of your pull requests: | |
- Check the status of your pull requests: |
pages/common/gh.md
Outdated
> Work seamlessly with GitHub from the command line. | ||
> More information: <https://cli.github.com/>. | ||
|
||
- View and filter a repository’s open issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- View and filter a repository’s open issues: | |
- View and filter repository’s open issues: |
pages/common/gh.md
Outdated
|
||
- Check out pull requests locally: | ||
|
||
`gh pr checkout` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is missing an argument. Official documentation says:
gh pr checkout {<number> | <url> | <branch>} [flags]
pages/common/gh.md
Outdated
|
||
- View a pull request in the browser: | ||
|
||
`gh pr view` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is missing argument as well. It should be noted which PR is to be viewed.
pages/common/gh.md
Outdated
|
||
- View an issue in the browser: | ||
|
||
`gh issue view` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is missing an argument, too.
pages/common/gh.md
Outdated
|
||
- View a pull request in the browser: | ||
|
||
`gh pr view {{1}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be a pain, but perhaps this would read better with a word instead. Like this?
`gh pr view {{1}}` | |
`gh pr view {{pr_number}}` |
Same goes for the other examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, any feedback is welcome for a newcomer in this repo
This is new stuff, right? I haven't seen that command ever before. |
Wait for @sbrl's approval before merging this. @schneiderl Yes, it's a fairly new thing. You can see it in the trending repositories every day, it's cli/cli. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I used to use the hub command, it seems hub can retire. |
Far from it @einverne. hub and gh's use cases are fairly different. But they may be merged in the future, who knows. |
Hey! Sorry I didn't get back to this in time. Thanks for merging :-) |
Sorry for the questions, this is my first pull request in this repository. Since it is a new command, which is supposed to be multi-platform, I placed into
common
directory.common/
,linux/
, etc.)