Skip to content

Conversation

antoniobusrod
Copy link
Contributor

Sorry for the questions, this is my first pull request in this repository. Since it is a new command, which is supposed to be multi-platform, I placed into common directory.

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@claassistantio
Copy link

claassistantio commented Feb 13, 2020

CLA assistant check
All committers have signed the CLA.

@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/gh.md:6: TLDR005 Example descriptions should end in a colon
pages/common/gh.md:10: TLDR005 Example descriptions should end in a colon
pages/common/gh.md:14: TLDR005 Example descriptions should end in a colon
pages/common/gh.md:18: TLDR005 Example descriptions should end in a colon
pages/common/gh.md:22: TLDR005 Example descriptions should end in a colon
pages/common/gh.md:26: TLDR005 Example descriptions should end in a colon
pages/common/gh.md:30: TLDR005 Example descriptions should end in a colon

Please fix the error(s) and push again.


`gh pr checkout`

- Check on the status of your pull requests:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Check on the status of your pull requests:
- Check the status of your pull requests:

> Work seamlessly with GitHub from the command line.
> More information: <https://cli.github.com/>.

- View and filter a repository’s open issues:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- View and filter a repository’s open issues:
- View and filter repository’s open issues:

@Geipro Geipro added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Feb 13, 2020

- Check out pull requests locally:

`gh pr checkout`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is missing an argument. Official documentation says:

gh pr checkout {<number> | <url> | <branch>} [flags]


- View a pull request in the browser:

`gh pr view`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is missing argument as well. It should be noted which PR is to be viewed.


- View an issue in the browser:

`gh issue view`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is missing an argument, too.


- View a pull request in the browser:

`gh pr view {{1}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be a pain, but perhaps this would read better with a word instead. Like this?

Suggested change
`gh pr view {{1}}`
`gh pr view {{pr_number}}`

Same goes for the other examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, any feedback is welcome for a newcomer in this repo

@schneiderl
Copy link
Collaborator

This is new stuff, right? I haven't seen that command ever before.

@zlatanvasovic zlatanvasovic requested a review from sbrl February 14, 2020 19:24
@zlatanvasovic
Copy link
Contributor

Wait for @sbrl's approval before merging this.

@schneiderl Yes, it's a fairly new thing. You can see it in the trending repositories every day, it's cli/cli.

Copy link
Member

@einverne einverne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@einverne
Copy link
Member

Wait for @sbrl's approval before merging this.

@schneiderl Yes, it's a fairly new thing. You can see it in the trending repositories every day, it's cli/cli.

I used to use the hub command, it seems hub can retire.

@zlatanvasovic
Copy link
Contributor

Far from it @einverne. hub and gh's use cases are fairly different. But they may be merged in the future, who knows.

@schneiderl schneiderl merged commit d009c90 into tldr-pages:master Feb 17, 2020
@antoniobusrod antoniobusrod deleted the add-gh-github-page branch February 17, 2020 08:05
@sbrl
Copy link
Member

sbrl commented Feb 17, 2020

Hey! Sorry I didn't get back to this in time. Thanks for merging :-)

mt-empty pushed a commit to mt-empty/tldr that referenced this pull request Feb 22, 2025
@dmmqz dmmqz mentioned this pull request Sep 18, 2025
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants