Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a way to avoid using containment operators #18

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

dannyzaken
Copy link
Contributor

when using a BTREE index, the use of containment operators prevents the query from hitting the index.

  • Added arraysOroptions to the convert function
    • maintaining previous functionality - if an array is passed it is treated as before. if an object, it is treated as options and arrays can also be passed inside the options object
  • If options.disableContainmentQuery is true then containment query is not used.
  • Added a simple unit test to test convert with options

Signed-off-by: Danny Zaken dannyzaken@gmail.com

when using a btree index, the use of containment operators prevents the query from hitting the index.
* added options to convert function and all the functions it's calling
* if options.disableContainmentQuery is true then containment query is not used.

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
@dannyzaken
Copy link
Contributor Author

@thomas4019. can you review this PR, please?

@thomas4019 thomas4019 merged commit ed9694c into thomas4019:master Jun 28, 2021
@thomas4019
Copy link
Owner

Looks great, I'll create a new release with this.

@dannyzaken
Copy link
Contributor Author

thanks for the quick merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants