-
Notifications
You must be signed in to change notification settings - Fork 726
fix: typo in cleanup link #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @cncolder, thanks for putting this PR :) |
@MatanBobi Really? I try again, and it's 404. |
There are 3 similar links on this page. Another links work for me except [`wrapper`](api.mdx#wrapper)
[`queries`](api.mdx#render-options)
[`Cleanup`](./api#cleanup) |
ah, if you nav from the home page. that's ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed fix
@all-contributors add @cncolder for docs |
I've put up a pull request to add @cncolder! 🎉 |
@nickmccurdy I think we'll need to do that for all the mdx's links. I wanted to verify it a little by navigating directly as @cncolder suggested just didn't get the chance yet. |
I verified the 3 links @cncolder mentioned on this page, before and after the changes. Did you want us to verify any other links or pages? |
My bad, sorry. I was pretty sure I removed all the |
It's alright. Is this done or should we make an issue to follow up with more changes/verification? |
I think that we're good for now :) I'll have another look at it today but on first glance it looks good. Thanks! |
No description provided.