Skip to content

fix: typo in cleanup link #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Conversation

cncolder
Copy link
Contributor

@cncolder cncolder commented Nov 9, 2020

No description provided.

@MatanBobi
Copy link
Member

Hi @cncolder, thanks for putting this PR :)
Am I missing something here? the current version does lead to where it should lead..

@cncolder
Copy link
Contributor Author

cncolder commented Nov 9, 2020

@MatanBobi Really? I try again, and it's 404.

Screen Recording 2020-11-10 at 00 34 37

@MatanBobi
Copy link
Member

That's odd.
ezgif-3-aa0ad5496333

Do other links work for you?

@cncolder
Copy link
Contributor Author

cncolder commented Nov 9, 2020

There are 3 similar links on this page. Another links work for me except Cleanup. 🤔

[`wrapper`](api.mdx#wrapper)
[`queries`](api.mdx#render-options)
[`Cleanup`](./api#cleanup)

@cncolder
Copy link
Contributor Author

cncolder commented Nov 9, 2020

ah, if you nav from the home page. that's ok.
but if you open setup page directly. you will see what happened.
because I come from google.

Copy link
Member

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fix

@nickserv nickserv merged commit 1a25a7b into testing-library:master Nov 10, 2020
@nickserv
Copy link
Member

@all-contributors add @cncolder for docs

@allcontributors
Copy link
Contributor

@nickmccurdy

I've put up a pull request to add @cncolder! 🎉

@MatanBobi
Copy link
Member

@nickmccurdy I think we'll need to do that for all the mdx's links. I wanted to verify it a little by navigating directly as @cncolder suggested just didn't get the chance yet.

@nickserv
Copy link
Member

I verified the 3 links @cncolder mentioned on this page, before and after the changes. Did you want us to verify any other links or pages?

@MatanBobi
Copy link
Member

I verified the 3 links @cncolder mentioned on this page, before and after the changes. Did you want us to verify any other links or pages?

My bad, sorry. I was pretty sure I removed all the .md extensions but apparently I just changed them to .mdx in the migration process, my thoughts are all messed up 😅 sorry :)

@nickserv
Copy link
Member

nickserv commented Nov 10, 2020

It's alright. Is this done or should we make an issue to follow up with more changes/verification?

@MatanBobi
Copy link
Member

I think that we're good for now :) I'll have another look at it today but on first glance it looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants