Skip to content

Conversation

MatanBobi
Copy link
Member

What: Prepare to migrate master branch to main

Why:

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

After that, we will need to rename the branch manually I guess..
I might be missing something because I'm not too familiar with how to do it so I just did it manually.
If there's an automatic process I don't know, please let me know :)

@MatanBobi MatanBobi requested review from eps1lon and nickserv April 22, 2021 07:42
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 22, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 662ad1f:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #901 (662ad1f) into master (7c84fa3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #901   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        26        26           
=========================================
  Hits           140       140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c84fa3...662ad1f. Read the comment docs.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will wait a bit to give others a chance to review.

Copy link
Member

@marcosvega91 marcosvega91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good :)

Copy link
Member

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but we'll also want to rename the branch on GitHub (relatively new feature) when it's merged.

@eps1lon
Copy link
Member

eps1lon commented Apr 25, 2021

This is good, but we'll also want to rename the branch on GitHub (relatively new feature) when it's merged.

Renamed before merge to see if this PR works as intended once merged.

@eps1lon eps1lon merged commit fe16376 into testing-library:main Apr 25, 2021
@github-actions
Copy link

🎉 This PR is included in version 11.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants