-
Notifications
You must be signed in to change notification settings - Fork 232
Release/5.0.0 docs #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/5.0.0 docs #529
Conversation
Also update examples to be more (imo) TS like
Codecov Report
@@ Coverage Diff @@
## beta #529 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 14 +2
Lines 186 203 +17
Branches 27 29 +2
=========================================
+ Hits 186 203 +17
Continue to review full report at Codecov.
|
Co-authored-by: Michael Peyper <mpeyper7@gmail.com>
Co-authored-by: Michael Peyper <mpeyper7@gmail.com>
Those are all the suggestion added, thanks for the grammer sweep, not sure if you wanna have one more glance over on the newest commit? |
Will do, but in the morning (passed midnight here now... I've been "finishing up for the night" for about 2 hours now 😅) |
I know that feeling! no rush of course lol. |
Co-authored-by: Michael Peyper <mpeyper7@gmail.com>
docs/usage/ssr-hooks.md
Outdated
--- | ||
name: SSR Hooks | ||
menu: Usage | ||
route: '/usage/ssr-hooks' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the route and the file should become just /usage/ssr
(I haven't done it as a suggestion because I can't rename the file to match).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do this, don't forger to update any links to this page (I saw at least one in api-reference
)
I think that last round of suggestions will just about do it. Good enough for the first release anyway. If history is any indicator, there will be plenty of PRs suggesting minor edits to them anyway, regardless of how much effort we put in now 😅 |
Co-authored-by: Michael Peyper <mpeyper7@gmail.com>
4ecbf4a
to
aa8b174
Compare
🎉 This PR is included in version 5.0.0-beta.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
hydrate
and re-wordact
to reflect rendererWhy:
Compliments the changes merged in #510 for #68
How:
Docz
Checklist: