Server Rendering #387
Closed
Server Rendering #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
============================================
- Coverage 100.00% 89.50% -10.50%
============================================
Files 4 13 +9
Lines 94 162 +68
Branches 15 22 +7
============================================
+ Hits 94 145 +51
- Misses 0 16 +16
- Partials 0 1 +1
Continue to review full report at Codecov.
|
|
I'm going to close this as it's getting very far behind master and there hasn't been much interest raised in it. If anyone is keen for it, or functionality like it, comment here and we might pick it up again. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This is an early look at what I'm thinking for #68.
It adds the ability to test hooks in different environments by allowing different renderers to be used. The library will ship with 3 renderers:
@testing-library/react-hooks/native(react-test-renderer)@testing-library/react-hooks/dom(react-dom)@testing-library/react-hooks/server(react-dom/server)Additionally, the main import for the package (
@testing-library/react-hooks) will autodetect which ofreact-domorreact-test-rendereris installed and select the appropriate renderer to use.Why:
Currently there was no way to test how a hook would behave when using rendering server side rendering.
#418 has also raised the issue that
refsare not being set when usingreact-test-rendererso this would also see a solution for users requiring that but being able to usereact-domto render instead.How:
By abstracting the rendering, rerendering and unmounting behaviour away from the core functionality, it was possible to provide thin renderer implementations that can leverage the same underlying logic. This opened the door to allowing DOM users to use use the existing renderer they have installed instead of having to install
react-test-rendererspecifically for this library.I would like to make it easier for other libraries to implement their own renderer on top of our core logic as well to make more use cases easier to implement (although I don't think we will ever ship more than the 3 renderers in this package). This would likely be using a
@testing-library/react-hooks/customimport, rather than drilling into thelib/coremodule.Docs are still to come and tests are not complete (but pretty close).
Checklist: