Skip to content

fix: add plugin name and version metadata for ESLint v9 #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: add plugin name and version metadata for ESLint v9 #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe554b9
fix: add plugin name and version metadata for ESLint v9
G-Rath Aug 4, 2024
273cea2
fix: correct types
G-Rath Aug 7, 2024
3b766d1
fix: don't "import" `package.json`
G-Rath Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,18 @@
import configs from './configs';
import rules from './rules';

// we can't natively import package.json as tsc will copy it into dist/
const {
name: packageName,
version: packageVersion,
// eslint-disable-next-line @typescript-eslint/no-var-requires
} = require('../package.json') as { name: string; version: string };

export = {
meta: {
name: packageName,
version: packageVersion,
},
configs,
rules,
};
5 changes: 3 additions & 2 deletions tools/generate-configs/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { type LinterConfigRules } from '../../lib/configs';
import { type TSESLint } from '@typescript-eslint/utils';

import rules from '../../lib/rules';
import {
SUPPORTED_TESTING_FRAMEWORKS,
Expand All @@ -11,7 +12,7 @@ const RULE_NAME_PREFIX = 'testing-library/';

const getRecommendedRulesForTestingFramework = (
framework: SupportedTestingFramework
): LinterConfigRules =>
): Record<string, TSESLint.Linter.RuleEntry> =>
Object.entries(rules)
.filter(
([
Expand Down