Skip to content

chore: improve dependencies #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build(deps): set @angular/forms and @testing-library/user-event as de…
…vDependencies

@angular/forms and @testing-library/user-event
are only used in tests and should not be exported
in the package.json for production.

@see: #272 (comment)
  • Loading branch information
the-ult committed Jan 6, 2022
commit 4b4a8c7bab3ece8e3f99825a4eed6971c28f6041
7 changes: 4 additions & 3 deletions .husky/_/husky.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
#!/bin/sh
if [ -z "$husky_skip_init" ]; then
debug () {
[ "$HUSKY_DEBUG" = "1" ] && echo "husky (debug) - $1"
if [ "$HUSKY_DEBUG" = "1" ]; then
echo "husky (debug) - $1"
fi
}

readonly hook_name="$(basename "$0")"
Expand All @@ -23,8 +25,7 @@ if [ -z "$husky_skip_init" ]; then

if [ $exitCode != 0 ]; then
echo "husky - $hook_name hook exited with code $exitCode (error)"
exit $exitCode
fi

exit 0
exit $exitCode
fi
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
"@angular/common": "13.0.2",
"@angular/compiler": "13.0.2",
"@angular/core": "13.0.2",
"@angular/forms": "13.0.2",
"@angular/material": "13.0.2",
"@angular/platform-browser": "13.0.2",
"@angular/platform-browser-dynamic": "13.0.2",
Expand All @@ -42,7 +41,6 @@
"@nrwl/angular": "13.2.2",
"@nrwl/nx-cloud": "12.5.4",
"@testing-library/dom": "^8.11.1",
"@testing-library/user-event": "^13.5.0",
"rxjs": "^7.4.0",
"tslib": "~2.3.1",
"zone.js": "~0.11.4"
Expand All @@ -54,6 +52,7 @@
"@angular-eslint/template-parser": "12.6.1",
"@angular/cli": "13.0.3",
"@angular/compiler-cli": "13.0.2",
"@angular/forms": "13.0.2",
"@angular/language-service": "13.0.2",
"@nrwl/cli": "13.2.2",
"@nrwl/eslint-plugin-nx": "13.2.2",
Expand All @@ -64,6 +63,7 @@
"@nrwl/workspace": "13.2.2",
"@testing-library/jasmine-dom": "^1.2.0",
"@testing-library/jest-dom": "^5.15.1",
"@testing-library/user-event": "^13.5.0",
"@types/jasmine": "^3.10.2",
"@types/jest": "27.0.3",
"@types/node": "14.14.37",
Expand Down
3 changes: 1 addition & 2 deletions projects/testing-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,12 @@
"peerDependencies": {
"@angular/common": ">= 13.0.0",
"@angular/platform-browser": ">= 13.0.0",
"@angular/animations": ">= 13.0.0",
"@angular/router": ">= 13.0.0",
"@angular/core": ">= 13.0.0"
},
"dependencies": {
"@testing-library/dom": "^8.0.0",
"tslib": "^2.0.0"
"tslib": "^2.3.1"
},
"publishConfig": {
"access": "public"
Expand Down