Skip to content

Fix/issue 263 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 26, 2021
Merged

Fix/issue 263 #264

merged 3 commits into from
Nov 26, 2021

Conversation

mleimer
Copy link
Contributor

@mleimer mleimer commented Nov 26, 2021

This PR is in response to #263 (comment)

  • It updates existing examples by using the new render-method to render templates
  • It adds a new example and a note how to render components with an attribute selector
  • It does not provide a solution how to handle components with an attribute selector without using a template

timdeschryver
timdeschryver approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timdeschryver
Copy link
Member

@all-contributors please add @mleimer for docs, tests

@allcontributors allcontributors bot mentioned this pull request Nov 26, 2021
Merged
@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @mleimer! 🎉

@mleimer mleimer mentioned this pull request Nov 26, 2021
Closed
@timdeschryver timdeschryver merged commit 224e550 into testing-library:beta Nov 26, 2021
@mleimer mleimer deleted the fix/issue-263 branch November 26, 2021 20:02
@github-actions
Copy link

🎉 This PR is included in version 11.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

timdeschryver pushed a commit that referenced this pull request Dec 3, 2021
@timdeschryver
docs: add selector with attribute example (#264)
eb06c83 
Closes #263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mleimer @timdeschryver