Skip to content

fix: rerender with template #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2021
Merged

fix: rerender with template #223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3133ed3
fix: rerender with template
Jun 3, 2021
36c4da2
Update projects/testing-library/src/lib/testing-library.ts
timdeschryver Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/testing-library/src/lib/testing-library.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@ function setComponentProperties<SutType>(
Object.defineProperty(fixture.componentInstance, key, {
get: descriptor?.get || defaultGetter,
set: extendedSetter,
// Allow the property to be defined again later.
// This happens when the component properties are updated after initial render.
// For Jest this is `true` by default, for Karma and a real browser the default is `false`
configurable: true,
});

descriptor?.set?.call(fixture.componentInstance, _value);
Expand Down