Skip to content

chore: migrate tslint to eslint #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: remove tslint and migrations
By removing the obsolete TSLint dependency, we need to remove the migrations as well. Since these depend on TSLint specific properties/types

BREAKING CHANGE: migrations for v4.0.0 and v5.1.2 are no longer available
  • Loading branch information
the-ult committed Apr 14, 2021
commit 1a2f75e42cfb3debf62dd48ce2b0de4d5746ce4a
6 changes: 0 additions & 6 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,6 @@
{
"command": "ng run testing-library:build-package"
},
{
"command": "tsc -p ./projects/testing-library/migrations/tsconfig.migrations.json"
},
{
"command": "cpy ./projects/testing-library/migrations/migration.json ./dist/@testing-library/angular/migrations"
},
{
"command": "cpy ./README.md ./dist/@testing-library/angular"
}
Expand Down
12 changes: 9 additions & 3 deletions nx.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
{
"implicitDependencies": {
"angular.json": "*",
"package.json": "*",
"tsconfig.json": "*",
"tslint.json": "*",
"package.json": {
"dependencies": "*",
"devDependencies": "*"
},
"tsconfig.base.json": "*",
".eslintrc.json": "*",
"nx.json": "*"
},
"affected": {
"defaultBase": "master"
},
"npmScope": "testing-library",
"tasksRunnerOptions": {
"default": {
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
"semantic-release": "^17.1.1",
"ts-jest": "26.5.4",
"ts-node": "9.1.1",
"tslint": "6.1.3",
"typescript": "4.1.4"
}
}
30 changes: 0 additions & 30 deletions projects/testing-library/migrations/4_0_0/index.ts

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

53 changes: 0 additions & 53 deletions projects/testing-library/migrations/5_1_2/index.ts

This file was deleted.

This file was deleted.

15 changes: 0 additions & 15 deletions projects/testing-library/migrations/migration.json

This file was deleted.

17 changes: 0 additions & 17 deletions projects/testing-library/migrations/tsconfig.migrations.json

This file was deleted.

2 changes: 1 addition & 1 deletion projects/testing-library/ng-package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"@testing-library/dom",
"@testing-library/user-event",
"@phenomnomnominal/tsquery",
"tslint"
"eslint"
]
}
5 changes: 1 addition & 4 deletions projects/testing-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,9 @@
"@testing-library/dom": "7.29.4",
"@phenomnomnominal/tsquery": "^4.1.1",
"tslib": "^2.0.0",
"tslint": "^5.16.0"
"eslint": "7.24.0"
},
"publishConfig": {
"access": "public"
},
"ng-update": {
"migrations": "./migrations/migration.json"
}
}
Loading