This repository was archived by the owner on Mar 30, 2022. It is now read-only.
Update parameter update doc. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update "Parameter Update" documentation using `KeyPathIterable` and `Differentiable`. Add "evolution from previous design" section.
dan-zheng
force-pushed
the
parameter-update
branch
from
635cda8 to
3e603f6
Compare
|
LGTM overall. How about a different name that mentions "optimizers" somewhere? "Hierarchical parameter iteration and optimizations"? |
Change title to "Hierarchical parameter iteration and optimization".
rxwei
approved these changes
Mar 8, 2019
|
Don't forget to also add a link on README. |
rxwei
reviewed
Mar 8, 2019
dan-zheng
force-pushed
the
parameter-update
branch
from
c06fea7 to
4be5f6d
Compare
rxwei
approved these changes
Mar 8, 2019
dan-zheng
commented
Mar 8, 2019
| } | ||
| ``` | ||
|
|
||
| We don't want to actually lower the for-loop or zip operation to TensorFlow (lowering wouldn't be straightforward or and lowered representation wouldn't be efficient). Instead, we want to fully unroll the loop into individual straight-line statements: |
There was a problem hiding this comment.
We don't want to actually lower the for-loop or zip operation to TensorFlow (lowering wouldn't be straightforward or and lowered representation wouldn't be efficient). Instead, we want to fully unroll the loop into individual straight-line statements:
Note: this efficiency concern was addressed later in the old version of this doc, but not in this updated version.
brettkoonce
pushed a commit
to brettkoonce/swift
that referenced
this pull request
Mar 14, 2019
Couple of minor copy edits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update "Parameter Update" documentation using
KeyPathIterableandDifferentiable.Add "evolution from previous design" section.