This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Make PrintX10Metrics available #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeta
reviewed
Apr 30, 2020
There was a problem hiding this comment.
Could you add a quick test to ensure we don't accidentally break this in the future (i.e. ensure that the symbol compiles and also that executing it doesn't crash*)?
- Ideally, we might be able to make certain assertions about its functionality, but I think it's okay to not go that far right now.
compnerd
previously approved these changes
Apr 30, 2020
|
Oh, and did you ensure that |
asuhan
force-pushed
the
asuhan/export_print_metrics
branch
from
d77c5e7 to
c01eaf3
Compare
|
|
compnerd
approved these changes
Apr 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.