Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

NonuniformInferenceBatches, as a type. #910

Merged

Conversation

dabrahams
Copy link
Contributor

The alternative to the typealias and the protocol hack would be to write a
wrapper around the type we've defined and make it conform to Collection, etc.

Dave Abrahams added 2 commits April 29, 2020 18:55
The alternative to the typealias and the protocol hack would be to write a
wrapper around the type we've defined and make it conform to Collection, etc.
Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@sgugger
Copy link
Contributor

sgugger commented Apr 30, 2020

@googlebot I fixed it (let's try if this works by any chance.)

@dabrahams dabrahams merged commit c64d104 into tensorflow:master Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants