This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Convert a LazyTensorTrace into a TFFunction. #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dan-zheng and I are at a conference. Perhaps @marcrasi can help with a readability review? |
Sounds good, Richard. |
eaplatanios
reviewed
Jun 20, 2019
eaplatanios
reviewed
Jun 20, 2019
eaplatanios
reviewed
Jun 20, 2019
eaplatanios
reviewed
Jun 20, 2019
eaplatanios
reviewed
Jun 20, 2019
eaplatanios
reviewed
Jun 20, 2019
marcrasi
reviewed
Jun 20, 2019
bgogul
commented
Jun 21, 2019
There was a problem hiding this comment.
Thanks for the review, @marcrasi and @eaplatanios I have addressed your comments. PTAL.
eaplatanios
reviewed
Jun 22, 2019
| outputGroupCounts.append(output.outputCount) | ||
| outputs += Array((0..<output.outputCount).map { | ||
| TF_Output(oper: graphNode, index: Int32($0)) | ||
| }) |
There was a problem hiding this comment.
TF_Output(oper: graphNode, index: Int32($0)) and }) should be indented by 4 spaces less each.
marcrasi
approved these changes
Jun 25, 2019
bgogul
force-pushed
the
tffunction_builder
branch
from
cf6aa28 to
cb6d032
Compare
rxwei
reviewed
Jun 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the functionality for the following conversions:
LazyTensorTrace->TFGraph->TFFunction