-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(qir2cirq): add a parameter 'args' for '_circuit_diagram_info_' #188
fix(qir2cirq): add a parameter 'args' for '_circuit_diagram_info_' #188
Conversation
…ke 'CustomizedCirqGate' work
thanks for the contribution, is this a cirq version related bug? since in https://github.com/tencent-quantum-lab/tensorcircuit/blob/master/tests/test_circuit.py#L948 we have tested the customized gate. if there is cirq version difference for this arg, maybe |
Aah, I didn't realize that. The version of my cirq is 1.2.0. Thanks for pointing out that😊. Should I close this PR and open a new one? |
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 75.51% 75.51%
=======================================
Files 67 67
Lines 10708 10708
=======================================
Hits 8086 8086
Misses 2622 2622
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think a further commit on your forked branch to define the function as |
Thanks for your help! I have made a new commit :) |
LGTM, thanks for the contribution. @all-contributors please add @ztzhu1 for code |
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @ztzhu1! 🎉 |
The original function
_circuit_diagram_info_
ofCustomizedCirqGate
lacks a parameter calledargs
, which will causeTypeError
whencirq
invokes this function.