Integration with AI SDK #1792

tconley1428 · 2025-10-02T23:32:21Z

What was changed

Added a new AiSDKPlugin to support running AI SDK in workflows. The plugin registers new activities for model invocation and optionally MCP tools. Workflows can then use temporalProvider to create models in workflows.

Why?

Checklist

Closes
How was this tested:
Added a new test suite with local model coverage. AI_SDK_REMOTE_TESTS env variable is available to run against a real endpoint.
Any docs updates needed?

.github/workflows/ci.yml

chris-olszewski

Apologies for slow review. My biggest concern is usage of any for some of the user facing types where ideally we would want to rely on the type system to prevent mismatching args.

packages/interceptors-opentelemetry/package.json

packages/ai-sdk/src/activities.ts

packages/ai-sdk/src/index.ts

packages/ai-sdk/src/mcp.ts

packages/ai-sdk/src/activities.ts

packages/ai-sdk/src/plugin.ts

packages/ai-sdk/src/mcp.ts

mjameswh · 2025-12-03T20:06:51Z

package.json

-    "@opentelemetry/api": "^1.7.0",
-    "@opentelemetry/core": "^1.19.0",
-    "@opentelemetry/sdk-node": "^0.46.0",
+    "@opentelemetry/api": "1.9.0",


Any reason we need these to have pinned versions instead of version ranges?

Chris said the same, I thought I updated it. Will check again

mjameswh · 2025-12-03T20:09:40Z

packages/worker/src/workflow/bundler.ts

    };

-    const compiler = webpack(this.webpackConfigHook(options));
+    const compiler = webpack(this.webpackConfigHook(options))!;


I don't see any reason for the non-null assertion operator on this line.

I have local issues with this for some reason, meant to remove it for PR.

mjameswh · 2025-12-03T20:13:42Z

packages/test/pnpm-lock.yaml

@@ -0,0 +1,5648 @@
+lockfileVersion: '9.0'


There should be no lockfile in this directory. It's probably the result of a mistake when you rebased your branch over Chris' works on switching the repo to PNPM.

Just delete the file, and the sibling node_modules directory if you have one on your local machine, then rerun pnpm i from the root of the project.

Sounds good

mjameswh · 2025-12-03T21:25:36Z

package.json

    "docs": "cd packages/docs && pnpm run maybe-install-deps-and-build-docs"
  },
  "dependencies": {
+    "@temporalio/ai-sdk": "workspace:*",


You also need to add to the meta package's pacakge.json, tsconfig.json and index.ts files. These control what's included in generated API docs.

mjameswh · 2025-12-03T21:31:25Z

packages/test/package.json

-    "@opentelemetry/sdk-trace-base": "^1.19.0",
-    "@opentelemetry/semantic-conventions": "^1.19.0",
+    "@modelcontextprotocol/sdk": "^1.10.2",
+    "@opentelemetry/api": "1.9.0",


Can we avoid pinned dependencies here?

mjameswh · 2025-12-03T22:23:39Z

packages/test/src/test-ai-sdk.ts

+import { Worker } from './helpers';
+import EventType = temporal.api.enums.v1.EventType;
+
+const remoteTests = !!process.env.AI_SDK_REMOTE_TESTS;


Do you know that !!"false" is true?

Please use the following idiom instead (or look at isSet in worker-options.ts).
That will ensure that this variable follows the same thruthness conventions as our other env variables.

Suggested change

const remoteTests = !!process.env.AI_SDK_REMOTE_TESTS;

const remoteTests = ['1', 't', 'true'].includes((process.env.AI_SDK_REMOTE_TESTS ?? 'false').toLowerCase()),

mjameswh · 2025-12-03T22:47:26Z

packages/test/src/test-ai-sdk.ts

+});
+
+test('Hello world agent responds in haikus', async (t) => {
+  t.timeout(120 * 1000);


I'm a bit worried about setting individual test timeout to 2 minutes. That means that eventual bugs that would prevent a worker from shutting down will cause the CI job to time out while running this test (which runs very early because ai starts with an a), with almost no context on what failed.

I suppose that's only pertinent when remoteTests is true, right?
And remoteTests would be false in CI, right?
If so, can we only bump up the test timeout to 2 minutes when remote tests are enabled?

Yeah, we could do that. I don't currently have it set to run the remoteTests at all in CI.

mjameswh · 2025-12-04T17:24:10Z

packages/ai-sdk/src/activities.ts

+    async invokeModel(
+      modelId: string,
+      options: LanguageModelV2CallOptions
+    ): Promise<{


Seems like this inline type is duplicated in doGenerate, and possibly other places. Can we extract that to a single name ddefinition?

mjameswh · 2025-12-04T20:16:15Z

packages/ai-sdk/src/activities.ts

+ *
+ * @experimental The AI SDK integration is an experimental feature; APIs may change without notice.
+ */
+export const createActivities = (provider: ProviderV2, mcpClientFactory?: (_: any) => Promise<MCPClient>): object => {


A few things:

Prefer the function syntax rather than the const lambda form unless there's a reason for the later;

Make a named type definition for McpClientFactory.

Make the arg's type unknown rather than any.

Suggested change

export const createActivities = (provider: ProviderV2, mcpClientFactory?: (_: any) => Promise<MCPClient>): object => {

// In mcp.ts

type McpClientFactory = (args: unknown) => Promise<MCPClient>;

export function createActivities(provider: ProviderV2, mcpClientFactory?: McpClientFactory): object {

mjameswh · 2025-12-04T20:21:39Z

packages/ai-sdk/src/activities.ts

+ */
+export const createActivities = (provider: ProviderV2, mcpClientFactory?: (_: any) => Promise<MCPClient>): object => {
+  const activities = {
+    async invokeModel(


Should we not namespace those activities somehow, to avoid eventual conflicts with user defined activities, or those from other plugins? Could be something like e.g. __ai_temporal_invokeModel?

We didn't in Python, and it does come with the downside of being UI clutter since the name is shown there.

mjameswh · 2025-12-04T20:56:04Z

packages/ai-sdk/src/activities.ts

+      return await model.doGenerate(options);
+    },
+  };
+  if (mcpClientFactory === undefined) {


I think we should still register the listTools and callTool activities even if there is no actual tool provided. The workflow side has no way to figure this out. listTools could return an empty array, and callTool could would throw the Tool xxcxc not found error, or even No tool registered.

That brings some reminders up for me. I need to reevaluate this to allow multiple MCP servers, that will change some things.

mjameswh · 2025-12-04T21:04:30Z

packages/ai-sdk/src/mcp.ts

+  ) {}
+
+  async tools(): Promise<ToolSet> {
+    const tools: Record<string, ListToolResult> = await workflow


Is it the way you did this in Python? I mean, listTools being an activity call, which is call everytime tools() is called?

A few things that can be considered to make this more efficient:

Cache tools after the first call

Make listTools a local activity call instead of a regular activity;

Extract the list of tools at bundle time and inject it as a static value into the workflow bundle (so no activity call needed to list tools).

It is one of the implementations we provided. Caching is a potential addition, but tools() is generally called once.

Extract the list of tools at bundle time and inject it as a static value into the workflow bundle (so no activity call needed to list tools).

I don't believe this is valid as the tool list is not known to be static.

mjameswh · 2025-12-04T21:07:17Z

packages/ai-sdk/src/plugin.ts

+import { SimplePlugin } from '@temporalio/plugin';
+import { createActivities } from './activities';
+
+export interface AiSDKPluginOptions {


Need an experimental annotation here. And also some docs.

mjameswh · 2025-12-04T21:12:40Z

packages/ai-sdk/src/plugin.ts

+ *
+ * @experimental The AI SDK plugin is an experimental feature; APIs may change without notice.
+ */
+export class AiSDKPlugin extends SimplePlugin {


nil: This is inconsistent. AI and SDK are both acronyms, and so both shoujld either be written with only the first letter in capital, or both entirely in uppercase.

Same for options.

mjameswh · 2025-12-04T21:19:03Z

packages/ai-sdk/src/provider.ts

+    warnings: Array<LanguageModelV2CallWarning>;
+  }> {
+    const result = await workflow
+      .proxyActivities(this.options ?? { startToCloseTimeout: '10 minutes' })


The ?? here will not guarantee that startToCloseTimeout is set, as this.options could be an empty object or similar.

Might be better to do { startToCloseTimeout: '10 minutes' , ...this.options } instead.

I'd also suggest doing that in the class constructor instead of here, but no strong strong opinion on that one.

Yeah, I think that's what I was thinking but not what I did, good call.

mjameswh · 2025-12-04T21:24:05Z

packages/ai-sdk/src/activities.ts

@@ -0,0 +1,88 @@
+import {


Suggested change

import {

import type {

mjameswh · 2025-12-04T21:24:51Z

packages/ai-sdk/src/provider.ts

@@ -0,0 +1,92 @@
+import {


Suggested change

import {

import type {

mjameswh · 2025-12-04T21:24:58Z

packages/ai-sdk/src/testing.ts

@@ -0,0 +1,99 @@
+import {


Suggested change

import {

import type {

mjameswh · 2025-12-04T21:26:54Z

packages/ai-sdk/package.json

+  "author": "Temporal Technologies Inc. <sdk@temporal.io>",
+  "license": "MIT",
+  "dependencies": {
+    "@ai-sdk/provider": "^2.0.0",


I was able to build the project with only type imports to the @ai/* packages, so it should be possible to lower these two dependencies to dev + peer dependencies instead of regular ones.

mjameswh · 2025-12-04T21:33:09Z

packages/ai-sdk/src/testing.ts

+ *
+ * @experimental The AI SDK integration is an experimental feature; APIs may change without notice.
+ */
+export class TestProvider implements ProviderV2 {


I'm not clear why it is pertinent for this mock to be part of our public API. That would be used in a user's tests on the worker side, not in workflow, so there's no concern regarding eventual import of non-workflow-safe code.

Doesn't the ai package itself provide this kind of test provider? Or some other external package that we could recommend instead of taking responsibility for this?

They have something kind of similar, although it doesn't do exactly what I needed. In Python we did expose it because OpenAI had basically no unit test support, but I could see an argument here for keeping it in test at least until there's a strong need.

mjameswh

See my previous comments.

tconley1428 added 14 commits September 16, 2025 09:32

Initial WIP on ai-sdk integration

bcb181b

Tools and a basic hello workflow now work

a04854e

Merge remote-tracking branch 'origin/main' into ai/initial

925bd9d

Leveraging plugin for AI SDK integration

d45be90

Some changes

c7af3f3

Add experimental telemetry validation

d334684

Merge remote-tracking branch 'origin/main' into ai/initial

a285bcc

Remove AI markdown

90c745a

Linting and project structure

fe533f2

Update dependencies

34fc1ca

Linting and project structure

c01f8bb

Fix build

a330d99

Linting

21bc8d5

Docstrings

181727c

tconley1428 changed the title ~~Ai/initial~~ Integration with AI SDK Nov 13, 2025

tconley1428 and others added 7 commits November 13, 2025 09:13

Merge branch 'main' into ai/initial

e7faeed

Clean up

844be62

Fix core version

843b112

Revert lock changes to minimum

839dabb

Adding MCP and activity config support

89948bd

Linting

fd9fbbc

Fix error suppression location after lint

bd5d9be

tconley1428 marked this pull request as ready for review November 17, 2025 18:34

tconley1428 requested a review from a team as a code owner November 17, 2025 18:34

mjameswh and others added 6 commits November 18, 2025 12:07

Test fix of the fetch-esm CI issue

613f32e

Bump GHA mac runners to macos15

022d814

Try using latest mcp server

a83c35d

Skip MCP test for now

bae6997

Merge remote-tracking branch 'origin/main' into ai/initial

5a89bd4

:wqMerge remote-tracking branch 'origin/main' into ai/initial

5396f36

Fix pnpm rebase

fafb2ac

tconley1428 commented Nov 21, 2025

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

chris-olszewski reviewed Nov 24, 2025

View reviewed changes

tconley1428 added 2 commits November 24, 2025 09:18

PR Feedback

4a66eb1

Update lockfile

e3f4d70

mjameswh mentioned this pull request Dec 2, 2025

[Feature Request] Temporal integration for @openai/agents #1755

Open

mjameswh reviewed Dec 3, 2025

View reviewed changes

mjameswh reviewed Dec 4, 2025

View reviewed changes

packages/ai-sdk/src/activities.ts

@@ -0,0 +1,88 @@

import {

Copy link

Contributor

mjameswh Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

import {

import type {

mjameswh reviewed Dec 4, 2025

View reviewed changes

packages/ai-sdk/src/provider.ts

@@ -0,0 +1,92 @@

import {

Copy link

Contributor

mjameswh Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

import {

import type {

mjameswh reviewed Dec 4, 2025

View reviewed changes

packages/ai-sdk/src/testing.ts

@@ -0,0 +1,99 @@

import {

Copy link

Contributor

mjameswh Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

import {

import type {

mjameswh reviewed Dec 4, 2025

View reviewed changes

mjameswh requested changes Dec 4, 2025

View reviewed changes

	const remoteTests = !!process.env.AI_SDK_REMOTE_TESTS;
	const remoteTests = ['1', 't', 'true'].includes((process.env.AI_SDK_REMOTE_TESTS ?? 'false').toLowerCase()),

-export const createActivities = (provider: ProviderV2, mcpClientFactory?: (_: any) => Promise<MCPClient>): object => {
+// In mcp.ts
+type McpClientFactory = (args: unknown) => Promise<MCPClient>;
+export function createActivities(provider: ProviderV2, mcpClientFactory?: McpClientFactory): object {

Integration with AI SDK #1792

Are you sure you want to change the base?

Integration with AI SDK #1792

Uh oh!

Conversation

tconley1428 commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What was changed

Why?

Checklist

Uh oh!

Uh oh!

chris-olszewski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tconley1428 commented Oct 2, 2025 •

edited

Loading