This repository was archived by the owner on Oct 24, 2023. It is now read-only.
bump ecmarkup and enable user code annotation #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User code annotation is still gated behind hitting
u, of course. And I haven't audited the annotations for correctness, though the spec text here seems like it should be amenable to the built-in analysis.This also enables linting, which currently finds 32 issues. At a glance they're mostly typos or non-Oxford spellings, but it looks like there's a few actual issues ("CloneArrayBuffer takes 3 arguments, but this invocation passes 4", for example).
You probably want to fix the lint issues before merging. I can take care of the trivial ones if you'd like; I have lots of practice at this point.