This repository was archived by the owner on Nov 27, 2023. It is now read-only.
generated from tc39/template-for-proposals
-
Notifications
You must be signed in to change notification settings - Fork 17
Rewrite spec to use generic List/Records #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should pave the way for TypedArray support.
ljharb
reviewed
Jul 15, 2021
bakkot
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the comment about ~empty~
. Also this is better anyway.
jridgewell
added a commit
that referenced
this pull request
Jul 15, 2021
This builds on #2 to add `TypedArray` support, where the values of the objects are instances of the `TypedArray` class.
Co-authored-by: Jordan Harband <ljharb@gmail.com>
jridgewell
commented
Jul 15, 2021
ljharb
reviewed
Jul 15, 2021
Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
approved these changes
Jul 15, 2021
jridgewell
added a commit
that referenced
this pull request
Jul 15, 2021
This builds on #2 to add `TypedArray` support, where the values of the objects are instances of the `TypedArray` class.
Merged
jridgewell
added a commit
that referenced
this pull request
Jul 15, 2021
* Add TypedArray Support This builds on #2 to add `TypedArray` support, where the values of the objects are instances of the `TypedArray` class. * Update spec.emu Co-authored-by: Kevin Gibbons <bakkot@gmail.com> * Fix merge conflict with changed numbers * Fix bug link bug * Update spec.emu Co-authored-by: Kevin Gibbons <bakkot@gmail.com> * fixup: [spec] `npm run build` Co-authored-by: Kevin Gibbons <bakkot@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should pave the way for TypedArray support.