Ensure K value in reverseK is at least 1 #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jserv
reviewed
Mar 16, 2025
qtest.c
Outdated
| if (!get_int(argv[1], &k)) { | ||
| report(1, "Invalid number of K"); | ||
| if (!get_int(argv[1], &k) || k < 1) { | ||
| report(1, "Invalid number of K = '%s'", argv[1]); |
There was a problem hiding this comment.
Refine the error message, addressing the valid range (at least 1).
EricccTaiwan
force-pushed
the
fix-reverseK
branch
from
461f8d0 to
d403b28
Compare
jserv
reviewed
Mar 16, 2025
qtest.c
Outdated
| if (!get_int(argv[1], &k)) { | ||
| report(1, "Invalid number of K"); | ||
| if (!get_int(argv[1], &k) || k < 1) { | ||
| report(1, "Invalid number of K = '%s' (at least 1)", argv[1]); |
There was a problem hiding this comment.
It is not necessary to print the value when K < 1. Improve the wording.
EricccTaiwan
force-pushed
the
fix-reverseK
branch
from
d403b28 to
273722d
Compare
jserv
reviewed
Mar 16, 2025
qtest.c
Outdated
| if (!get_int(argv[1], &k)) { | ||
| report(1, "Invalid number of K"); | ||
| if (!get_int(argv[1], &k) || k < 1) { | ||
| report(1, "Invalid number of K (at least 1)", argv[1]); |
Passing 0 or a negative value for K does not cause errors, as the input is an integer. However, this behavior may be confusing for users. To improve clarity, enforce K to be an integer greater than or equal to 1 and return an error if the input is invalid. Co-authored-by: Po-Ying Chiu <charlie910417@gmail.com> Change-Id: I6741888f888523d00f83cd554fc1442e99120a64
EricccTaiwan
force-pushed
the
fix-reverseK
branch
from
273722d to
e9071f4
Compare
|
Thank @EricccTaiwan for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing 0 or a negative value for K does not cause errors, as the input is an integer. However, this behavior may be confusing for users. To improve clarity, enforce K to be an integer greater than or equal to 1 and return an error if the input is invalid.
Change-Id: Ic68c1acbbd45153da8c3d7682d9251eec9ce597f
Before
After