Support file manager callback "URLs" #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd brought up in a support ticket that I'd wanted to submit a PR for a feature we need in order to use this our application, and got the general okay pending signing a contributor agreement. Still waiting on that document, but figured I'd go ahead and send this over anyway.
The idea here is that we need to be able to pass in event handlers that will inject custom logic into the component, rather than simply uploading to and downloading from hardcoded URLs.
I haven't tested any of this (or looked into setting up a local build/test environment at all), but it at least compiles successfully in my editor (vscode) and seems like a simple enough change that I wouldn't expect any regressions.