Skip to content

Move activeView check to refreshDataManager #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

cxspxr
Copy link

@cxspxr cxspxr commented Mar 4, 2021

See #97

cxspxr added 2 commits March 4, 2021 14:06
Renderer.refreshDataManager is invoked not only from render but also from Schedule.onPropertyChange and possibly also in other places
So it is better to check activeView directly in refreshDataManager to ensure there is activeView set there.
@cxspxr
Copy link
Author

cxspxr commented Mar 4, 2021

18.4.46 did fix one source of the issue, but then the issue appeared in different place again. See #97 for more info.

With this fix in this PR now directly applied inside node_modules we don't have the issue anymore. We guess it is better to move the check of activeView directly to the refreshDataManager method. In that way it should fix the issue completely, not just in some place where it is invoked, because as we know now refreshDataManager is invoked in multiple places.

@maheshtps
Copy link

Dear Customer,

Thanks for providing pull request.

We have included the same changes in our weekly release in version 18.4.48.

Release notes:
https://ej2.syncfusion.com/react/documentation/release-notes/18.4.48/?type=all#schedule

Regards,
Mahesh

@rajendranr-5483
Copy link
Collaborator

Dear Customer,

Since we included your changes, we will close this pull request. If any issue, kindly reopens it.

Regards,
Rajendran R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants