don't write null to stream if response is empty

[xprotocol-bot]

No description provided.

[dunglas]

Could you add a test please? Also, isn't it possible to prevent the call to isEmpty() by just checking the return value of getContent()?

[xprotocol-bot]

Hi. Yes I've just did that.
My old approach based on Dingo\Api\Http\Response and that one based on an old version of \Symfony\Component\HttpFoundation\Response which still allows $content to be null. And that how the bug happened.

Now current version of \Symfony\Component\HttpFoundation\Response enforce return type of getContent must be string|false so I've just updated the PR following that. And this fix will still work for the old version of \Symfony\Component\HttpFoundation\Response

[xprotocol-bot]

Hi. Looks like one of the checks is stucked?

[derrabus]

I'm not sure if this if the correct fix. If getContent() returns false, this usually does not mean that there is no content. It means that the content is generated when sending the response.

[xprotocol-bot]

I'm not sure if this if the correct fix. If getContent() returns false, this usually does not mean that there is no content. It means that the content is generated when sending the response.

Is that case handled in: https://github.com/symfony/psr-http-message-bridge/blob/main/Factory/PsrHttpFactory.php#L136? And yeah I started to think that this might not be necessary because I got the bug because of the behavior of Dingo\Api\Http\Response when it returns 304 status code and empty content. And this library might not be responsible for handling such case.