Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix .swift-version unused when swift-version option unset #24

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Fix .swift-version unused when swift-version option unset #24

merged 4 commits into from
Jan 15, 2023

Conversation

sidepelican
Copy link
Contributor

Fix #23. Simply removed the default value.

@kateinoigakukun
Copy link
Member

kateinoigakukun commented Jan 15, 2023 •
edited
Loading

Can we use the default version wasm-5.7.1-RELEASE when no .swift-version and no swift-version are specified?

@sidepelican
Copy link
Contributor Author

OK. added defaultSwiftVersion in script.

kateinoigakukun
kateinoigakukun approved these changes Jan 15, 2023
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kateinoigakukun kateinoigakukun merged commit 1deb850 into swiftwasm:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Action does not read .swift-version
2 participants
@sidepelican @kateinoigakukun